Removing getCertificate() from the Credential interface#576
Merged
hiranya911 merged 4 commits intomasterfrom Jun 27, 2019
Merged
Removing getCertificate() from the Credential interface#576hiranya911 merged 4 commits intomasterfrom
hiranya911 merged 4 commits intomasterfrom
Conversation
Contributor
|
Some other places: firebase-admin-node/src/utils/index.ts Line 72 in 9f770b4 |
samtstern
approved these changes
Jun 19, 2019
bojeil-google
approved these changes
Jun 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Credentialis a public interface and is declared as follows in the typings:But in the actual implementation (credential.ts), there's an additional method in the interface:
firebase-admin-node/src/auth/credential.ts
Lines 291 to 294 in 843df12
This can cause issues if the developer implements the public
Credentialinterface, and passes it throughAppOptions. Internal code that expects to find agetCertificate()method will fail.This PR addresses this issue by separating the
getCertificate()method from theCredentialinterface.Resolves #573